[two_auctions.md] Update np.random → Generator API#960
Open
Chihiro2000GitHub wants to merge 1 commit into
Open
[two_auctions.md] Update np.random → Generator API#960Chihiro2000GitHub wants to merge 1 commit into
Chihiro2000GitHub wants to merge 1 commit into
Conversation
40 tasks
📖 Netlify Preview Ready!Preview URL: https://pr-960--sunny-cactus-210e3e.netlify.app Commit: 📚 Changed LecturesBuild Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates legacy NumPy random API usage in
two_auctions.mdas part of QuantEcon/meta#299.The
np.random.seed(1337)/np.random.uniform(...)/np.random.chisquare(...)calls are replaced with an explicitrng = np.random.default_rng(1337)and the correspondingrng.uniform(...)/rng.chisquare(...)methods. The lecture intentionally re-seeds to reproduce the same valuations across blocks, sorngis re-created with the same seed at those points, preserving the original reproducibility. There are no Numba-related concerns in this file.Hi @mmcky and @HumphreyYang, I'd be grateful if you could take a look when you have time.