Fix check ID error in helpGeneric.R#158
Open
smasongarrison wants to merge 11 commits into
Open
Conversation
Up to standards ✅🟢 Issues
|
Updated the .pedigreeRelatednessMatrix function to ensure that the matrix is always coerced to a base dense matrix after symmetrization. Added error handling for matrix creation.
smasongarrison
force-pushed
the
dev_main
branch
2 times, most recently
from
5944299 to
aebbafa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces utility functions for matrix handling and improves the clarity and robustness of parent ID validation output.
Matrix handling utilities:
as_numeric_matrixto coerce objects to numeric matrices, ensuring consistent numeric storage for downstream processing.make_symmetric, which symmetrizes matrices (averages with their transpose) when needed, to guarantee exact symmetry as required by OpenMx.Validation output improvements:
checkParentIDs, improved handling of individuals appearing in bothmomIDanddadIDby filtering outNAvalues and formatting the output for better readability.