makefiles/pseudomodules: sort and enhance documentation#22397
Open
crasbe wants to merge 1 commit into
Open
Conversation
crasbe
added
Type: enhancement
crasbe
force-pushed
the
pr/pseudomodule_sort
branch
from
6970cbe to
b335512
Compare
basilfx
reviewed
Jun 23, 2026
basilfx
reviewed
Jun 23, 2026
| ## @deprecated Will be removed after the 2021.07 release. | ||
| PSEUDOMODULES += sema_deprecated | ||
| ## @} | ||
| PSEUDOMODULES += semtech_loramac_rx |
Member
There was a problem hiding this comment.
This would violate the rule on line 36, right? One blank line between a documented module and the following unrelated module?
Contributor
Author
There was a problem hiding this comment.
Technically yes, although when the closing bracket is used, I thought it would be enough visual distinction.
In an earlier version of the rules, I had that written out, but then I thought it would be too verbose.
basilfx
approved these changes
Jun 23, 2026
crasbe
force-pushed
the
pr/pseudomodule_sort
branch
from
379f249 to
6804c6c
Compare
crasbe
added
the
Process: blocked by feature freeze
Contributor
Author
|
I'll wait with the merge until after the feature freeze. If something got screwed up, this is more likely to be discovered after the release than before the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The Pseudomodule list has become a bit of a mess, so I sorted it, shortened lines, added documentation and a short "how to".
I'm sure it is not perfectly inherently sorted (as in:
wifi_blamight be behindwifi_blubb), but I don't want to go that far :DTesting procedure
CI should catch any lost pseudomodules (maybe?).
Issues/PRs references
None.
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: