Clean Up Compilation Failures on Non-GFX1250 Targets#326
Draft
alex-breslow-amd wants to merge 4 commits into
Draft
Clean Up Compilation Failures on Non-GFX1250 Targets#326alex-breslow-amd wants to merge 4 commits into
alex-breslow-amd wants to merge 4 commits into
Conversation
* Put in stubs * Add kernel and fix up * Finalize tunability of threads per block and number of blocks. * Implement pipelining * Add debugging logic * Fix segfault * Disable debug prints * Add missing timing information * Add TDM_BLOCK_SIZE, TDM_MAX_LDS_BYTES, and TDM_PIPELINED env vars to control TDM kernel execution * Not functioning but proof of concept async load/store implementation * Fix async load store kernel MVP * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Tim <43156029+AtlantaPepsi@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…n. To be collapsed into the main load store path.
AtlantaPepsi
force-pushed
the
candidate-1.68
branch
from
be5f315 to
33d0bf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TDM logic wasn't properly gated for gfx942/gfx950 causing compilation failures
Reduced code duplication on gfx path to allow for expansion so that we can mix and match different load/store methodologies more easily going forward
Technical Details
TDM is only available on gfx1250
Test Plan
Ran on gfx950 system and verified that it works
Test Result
See above
Submission Checklist