Integrate AHU and simplified, inert transfer systems into ROM#1607
Integrate AHU and simplified, inert transfer systems into ROM#1607HoeppJ wants to merge 120 commits into
Conversation
…tem-behavior-to-rom-simulation' into 1572-add-simplified-transfer-system-behavior-to-rom-simulation
…tem-behavior-to-rom-simulation' into 1572-add-simplified-transfer-system-behavior-to-rom-simulation
Updated Dynamic Volume Flow control in AHU and added dynamic supply temperature control for AHU
Updated Dynamic Volume Flow control in AHU and added dynamic supply temperature control for AHU
…tem-behavior-to-rom-simulation' into 1572-add-simplified-transfer-system-behavior-to-rom-simulation
…d_transfer_and_ahu
…ulation' into simplified_transfer_and_ahu
|
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /simplified_transfer_and_ahu/charts/
|
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /simplified_transfer_and_ahu/charts/
HvanderStok
left a comment
HvanderStok
left a comment
There was a problem hiding this comment.
Thanks for the work! Can you just increase the version from 3.0.0 to 3.1.0 and then everything looks good from my site.
|
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /simplified_transfer_and_ahu/charts/
…o simplified_transfer_and_ahu
|
Errors in regression test. Compare the results on the following page |
3 similar comments
|
Errors in regression test. Compare the results on the following page |
|
Errors in regression test. Compare the results on the following page |
|
Errors in regression test. Compare the results on the following page |
|
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/simplified_transfer_and_ahu/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /simplified_transfer_and_ahu/charts/
HvanderStok
left a comment
HvanderStok
left a comment
There was a problem hiding this comment.
Do you want to fix #1640 also in this PR? In my opinion, we should do an own PR for it. But as you already changed the PITemp model here, I would suggest fixing the bug I encountered as described in #1641 within this PR. When you agree on how to fix it, I also can do it. And you still need to increase the version number.
There was a problem hiding this comment.
In the review of this model, I encountered an old bug, which I described in #1641. We should fix it directly with this PR.
5 participants
This pull request targets bug fixes in new modular AHU - merged into main in #834 - (Issue #1586), integrating the new modular AHU in ROM (Issue #1579) and adding an simplified approach to integrate inert heat/cool transfer system behavior into ROM (Issues #1572)