Fix #5312 | Rewrite the iOS Feed Inspector in SwiftUI#5316
Open
stuartbreckenridge wants to merge 2 commits into
Open
Fix #5312 | Rewrite the iOS Feed Inspector in SwiftUI#5316stuartbreckenridge wants to merge 2 commits into
stuartbreckenridge wants to merge 2 commits into
Conversation
Retire the old storyboard-bound view controller in favour of a SwiftUI implementation, presented via UIHostingController from the scene coordinator. The storyboard now keeps only what it absolutely must, and the venerable FeedInspectorViewController has been politely shown the door.
brentsimmons
modified the milestones:
NetNewsWire 7.2,
NetNewsWire 7.1.1,
NetNewsWire 7.1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5312
The FeedInspectorViewController has been politely shown the door and replaced with a SwiftUI equivalent that restores the copy/paste behaviours.
Other changes to note: