Skip to content

fix: current device logout showing error#40351

Draft
juliajforesti wants to merge 4 commits into
developfrom
fix/current-device-logout
Draft

fix: current device logout showing error#40351
juliajforesti wants to merge 4 commits into
developfrom
fix/current-device-logout

Conversation

@juliajforesti

@juliajforesti juliajforesti commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

CORE-2033

Proposed changes (including videos or screenshots)

issue:

  • calling the logout API endpoint /v1/sessions/logout.me triggered a refetch of the device list
  • at that point the user was already logged out, causing a 401 authentication error
  • the 401 error displayed the "Something went wrong" page briefly before redirecting to login

solution:

  • Conditional query invalidation:
    • detect when logging out own session (/v1/sessions/logout.me) vs logging out other users' sessions
    • for own session logout, skip query invalidation entirely since the user is being logged out anyway
  • Add throwOnError: false to the mutation to prevent errors from reaching React error boundaries

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot

dionisio-bot Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 8.7.0, but it targets 8.6.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Apr 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f18c08c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c14f0d68-bf09-4b69-b827-d179f858c904

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.10%. Comparing base (2a58e30) to head (f18c08c).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #40351      +/-   ##
===========================================
- Coverage    70.10%   70.10%   -0.01%     
===========================================
  Files         3357     3357              
  Lines       129543   129552       +9     
  Branches     22463    22421      -42     
===========================================
- Hits         90819    90817       -2     
- Misses       35421    35440      +19     
+ Partials      3303     3295       -8     
Flag Coverage Δ
e2e 59.22% <31.57%> (-0.04%) ⬇️
e2e-api 46.31% <ø> (-0.78%) ⬇️
unit 70.06% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alfredodelfabro alfredodelfabro added this to the 8.6.0 milestone Jun 9, 2026
@juliajforesti juliajforesti force-pushed the fix/current-device-logout branch from 3340fda to f18c08c Compare June 16, 2026 13:25
@scuciatto scuciatto modified the milestones: 8.6.0, 8.7.0 Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants