fix: Missing a visible quote message link #41091
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
WalkthroughQuoteAttachment.tsx now renders quote timestamp and message-link content through separate structure components instead of wrapping the timestamp text in an anchor. Two new attachment structure components were added to support that split. ChangesQuote attachment link fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/jira CORE |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #41091 +/- ##
===========================================
- Coverage 70.09% 69.15% -0.94%
===========================================
Files 3363 3435 +72
Lines 129716 132341 +2625
Branches 22444 23048 +604
===========================================
+ Hits 90925 91525 +600
- Misses 35479 37451 +1972
- Partials 3312 3365 +53
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
dougfabris
force-pushed
the
fix/quote-link-affordance
branch
from
cad7a06 to
1480e61
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@apps/meteor/client/components/message/content/attachments/structure/AttachmentMessageLink.tsx`:
- Line 1: The AttachmentMessageLink type annotation is using a type-only Box
import, so `ComponentPropsWithoutRef<typeof Box>` cannot resolve a value-side
component reference. Update the imports in AttachmentMessageLink to bring `Box`
in as a normal runtime import, matching the pattern used in
AttachmentAuthorTimestamp, so the `typeof Box` usage in the component type
definition works correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1d2a671d-323e-4843-adf6-54a03457dd95
📒 Files selected for processing (3)
apps/meteor/client/components/message/content/attachments/QuoteAttachment.tsxapps/meteor/client/components/message/content/attachments/structure/AttachmentAuthorTimestamp.tsxapps/meteor/client/components/message/content/attachments/structure/AttachmentMessageLink.tsx
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
- GitHub Check: Hacktron Security Check
- GitHub Check: CodeQL-Build
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/components/message/content/attachments/structure/AttachmentAuthorTimestamp.tsxapps/meteor/client/components/message/content/attachments/structure/AttachmentMessageLink.tsxapps/meteor/client/components/message/content/attachments/QuoteAttachment.tsx
🧠 Learnings (2)
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.
Applied to files:
apps/meteor/client/components/message/content/attachments/structure/AttachmentAuthorTimestamp.tsxapps/meteor/client/components/message/content/attachments/structure/AttachmentMessageLink.tsxapps/meteor/client/components/message/content/attachments/QuoteAttachment.tsx
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
apps/meteor/client/components/message/content/attachments/structure/AttachmentAuthorTimestamp.tsxapps/meteor/client/components/message/content/attachments/structure/AttachmentMessageLink.tsxapps/meteor/client/components/message/content/attachments/QuoteAttachment.tsx
🔇 Additional comments (3)
apps/meteor/client/components/message/content/attachments/structure/AttachmentAuthorTimestamp.tsx (1)
1-9: LGTM!apps/meteor/client/components/message/content/attachments/structure/AttachmentMessageLink.tsx (1)
7-11: 🎯 Functional CorrectnessIcon-only button vs. screenshot's visible "Jump to message" text.
The PR's before/after screenshots show a visible "Jump to message" text link, but this renders as an icon-only
IconButton(label only surfaces via hover tooltip/title). Worth confirming this still meets the discoverability goal from the linked issue, or whether a visible text label was intended.apps/meteor/client/components/message/content/attachments/QuoteAttachment.tsx (1)
3-3: LGTM!Also applies to: 12-16, 61-62
dougfabris
force-pushed
the
fix/quote-link-affordance
branch
from
1480e61 to
35e2a61
Compare
1 participant
Proposed changes (including videos or screenshots)
Currently our quote messages doesn't have a visible link, instead the link to jump to the original message is placed in the timestamp which doesn't offer a good affordance for such action. This PR aims to add a clear link for the user to jump to the original message
before
after
Issue(s)
Closes #31747
Steps to test or reproduce
Further comments
Task: CORE-2352
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes