regression: long DM custom status overlaps room header action icons#41108
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.6.0 #41108 +/- ##
================================================
Coverage ? 70.19%
================================================
Files ? 3371
Lines ? 130416
Branches ? 22615
================================================
Hits ? 91539
Misses ? 35556
Partials ? 3321
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
In a DM, a long custom status from the partner overflowed the room header and overlapped the action/options icons.
#40469 moved the DM partner's status out of
RoomTopic(which rendered it truncated) into the newRoomMemberStatus, which rendered it with no truncation.RoomMemberStatusnow renders the status as a bareMarkdownTextwithwithTruncatedText— matchingRoomTopic— so it clips with an ellipsis within the available header space instead of spilling into the toolbar.Regression introduced by #40469.
Issue(s)
Steps to test or reproduce
Before: the status overflows horizontally and overlaps the header action icons.
After: the status truncates with an ellipsis and stays within the header.
Further comments
Summary by CodeRabbit