Skip to content

regression: long DM custom status overlaps room header action icons#41108

Merged
dionisio-bot[bot] merged 1 commit into
release-8.6.0from
regression/dm-header-status-overflow
Jun 30, 2026
Merged

regression: long DM custom status overlaps room header action icons#41108
dionisio-bot[bot] merged 1 commit into
release-8.6.0from
regression/dm-header-status-overflow

Conversation

@ricardogarim

@ricardogarim ricardogarim commented Jun 29, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

In a DM, a long custom status from the partner overflowed the room header and overlapped the action/options icons.

#40469 moved the DM partner's status out of RoomTopic (which rendered it truncated) into the new RoomMemberStatus, which rendered it with no truncation. RoomMemberStatus now renders the status as a bare MarkdownText with withTruncatedText — matching RoomTopic — so it clips with an ellipsis within the available header space instead of spilling into the toolbar.

Regression introduced by #40469.

Issue(s)

Steps to test or reproduce

  1. Open a DM with a user who has a long custom status.
  2. Use a normal or narrow desktop viewport.

Before: the status overflows horizontally and overlaps the header action icons.
After: the status truncates with an ellipsis and stays within the header.

Further comments

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Improved member status display by showing truncated text with a full hover title, making long presence/expiration messages easier to read.
    • Simplified the status rendering so the message now appears directly without extra surrounding spacing.

@ricardogarim ricardogarim added this to the 8.6.0 milestone Jun 29, 2026
@dionisio-bot

dionisio-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f30215e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 833ff0a0-469b-4c0f-a064-e21ed1f6cc2e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.6.0@5857fb0). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-8.6.0   #41108   +/-   ##
================================================
  Coverage                 ?   70.19%           
================================================
  Files                    ?     3371           
  Lines                    ?   130416           
  Branches                 ?    22615           
================================================
  Hits                     ?    91539           
  Misses                   ?    35556           
  Partials                 ?     3321           
Flag Coverage Δ
e2e 59.49% <100.00%> (?)
e2e-api 47.02% <ø> (?)
unit 70.11% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardogarim ricardogarim marked this pull request as ready for review June 30, 2026 12:13
@ricardogarim ricardogarim requested a review from a team as a code owner June 30, 2026 12:13

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jun 30, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 30, 2026
@dionisio-bot dionisio-bot Bot merged commit 4d6eafa into release-8.6.0 Jun 30, 2026
82 of 85 checks passed
@dionisio-bot dionisio-bot Bot deleted the regression/dm-header-status-overflow branch June 30, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants