Skip to content

[INTERNAL] Groundwork for extension projects#4

Closed
RandomByte wants to merge 4 commits into
masterfrom
extension-handling
Closed

[INTERNAL] Groundwork for extension projects#4
RandomByte wants to merge 4 commits into
masterfrom
extension-handling

Conversation

@RandomByte

@RandomByte RandomByte commented Apr 9, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

See RFC 0001.

Identify and apply extensions in dependency tree so that they can
influence the actual project processing.

Related to SAP/ui5-builder#5

CC: @tommyvinhlam @Thodd

devtomtom
devtomtom reviewed Apr 11, 2018
View reviewed changes
Comment thread lib/projectPreprocessor.js Outdated
@RandomByte
RandomByte force-pushed the extension-handling branch from e64cde6 to a56609d Compare June 14, 2018 15:42
@RandomByte

RandomByte commented Jun 18, 2018

Copy link
Copy Markdown
Member Author

Shim extension related to UI5/cli#5

@RandomByte RandomByte mentioned this pull request Jul 17, 2018
Merged
@CLAassistant

CLAassistant commented Oct 8, 2018 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

CLAassistant commented Oct 8, 2018

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls

coveralls commented Oct 8, 2018 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 190

  • 41 of 59 (69.49%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.935%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/projectPreprocessor.js 41 59 69.49%
Totals Coverage Status
Change from base Build 187: 0.0%
Covered Lines: 169
Relevant Lines: 231
💛 - Coveralls

RandomByte added a commit to RandomByte/openui5-parallax that referenced this pull request Oct 8, 2018
@RandomByte
Enable for UI5 Tooling usage
c1cd466 
Depends on SAP/ui5-project#4
@RandomByte RandomByte mentioned this pull request Oct 8, 2018
Closed
@RandomByte
RandomByte requested review from matz3 and svbender October 8, 2018 12:29
@RandomByte
[FEATURE] Add "extension" projects
116b196 
See [RFC0001](UI5/cli#4).

Identify and apply extensions in dependency tree so that they can
influence the actual project processing.
@RandomByte
[FEATURE] Add shim extension
851b87b
@RandomByte
[INTERNAL] Apply extensions found in root project
3af303c
@RandomByte
[INTERNAL] Apply extensions only once
4852ce0 
Also enhance extension metadata checks
@matz3 matz3 closed this Oct 12, 2018
@matz3 matz3 reopened this Oct 12, 2018
@RandomByte

RandomByte commented Oct 12, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Superseded by #46

@RandomByte RandomByte closed this Oct 12, 2018
@RandomByte
RandomByte deleted the extension-handling branch October 12, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matz3 matz3 Awaiting requested review from matz3
@svbender svbender Awaiting requested review from svbender
1 more reviewer
@devtomtom devtomtom devtomtom left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RandomByte @CLAassistant @coveralls @devtomtom @matz3