Add package-lock.json schema#5739
Draft
Vessel9817 wants to merge 25 commits into
Draft
Conversation
Vessel9817
commented
May 30, 2026
Vessel9817
left a comment
Vessel9817
left a comment
Contributor
Author
There was a problem hiding this comment.
Since package.json puts a constraint on bundledDependencies and bundleDependencies such that one or neither of them must exist, not both, using a ref on that schema seems to be affected by ajv-validator/ajv#1571. If this isn't the case, then it'd appear that strict mode has different validation logic for refs in external files.
Contributor
Author
|
Blocked by ajv-validator/ajv#2635 |
Vessel9817
commented
Jun 23, 2026
Vessel9817
left a comment
Vessel9817
left a comment
Contributor
Author
There was a problem hiding this comment.
Blocked by #5836, as this could also resolve the above issue.
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
for more information, see https://pre-commit.ci
Vessel9817
commented
Jun 24, 2026
Vessel9817
left a comment
Vessel9817
left a comment
Contributor
Author
There was a problem hiding this comment.
Unblocked, since #5836 was merged into master. Rebasing.
Vessel9817
force-pushed
the
package-lock.json
branch
from
47ba1fe to
2dd2f29
Compare
This reverts commit 2b58052. Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Wasn't able to figure out how to `$ref` `package.json`, so the appropriate values have been copied over. Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
This reverts commit 15f437f. Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Vessel9817
commented
Jun 27, 2026
Vessel9817
left a comment
Vessel9817
left a comment
Contributor
Author
There was a problem hiding this comment.
Since beginning, I've learned more about schema-validation.jsonc, which makes the changes to package.json more or less useless. Disabling strict mode validation alleviates the need to migrate the package.json to strict mode validation.
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5738