refactor(Sample-Datasets): replace old table with dynamic-mat-table and fix pagination bugs

[abdimo101]

Description

This PR replaces the old sample datasets table with dynamic-mat-table and fixes pagination bugs.

Before:

After:

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

• Items added

Changes:

Please provide a list of the changes implemented by this PR

• changes made

Tests included

• Included for each change/fix?
• Passing? (Merge will not be approved unless this is checked)

Documentation

• swagger documentation updated [required]
• official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

• Does it require a specific version of the backend
• which version of the backend is required:

Summary by Sourcery

Replace the sample detail datasets table with the shared dynamic material table and align dataset fetching and pagination with server-side APIs.

New Features:

• Introduce a dynamic material table for displaying related datasets in the sample detail view, including empty-state messaging and configurable pagination.

Bug Fixes:

• Fix incorrect datasets count retrieval by switching to the dedicated count endpoint.
• Resolve pagination inconsistencies by wiring dynamic table pagination to the NgRx store and backend server-side pagination parameters.
• Fix row navigation by handling dynamic table row click events and using dataset PID from the table row data.

Enhancements:

• Standardize table column definitions and styling using shared dynamic-material-table models.
• Refine related datasets tab labelling and row styling for improved clarity and consistency.

[sourcery-ai]

Hey - I've left some high level feedback:

• You now have multiple subscriptions to vm$ in SampleDetailComponent that each handle different concerns (attachments, table data, pagination); consider consolidating these into a single subscription or using tap in the selector to reduce duplicate subscription logic and make state updates easier to reason about.
• Instead of maintaining a BehaviorSubject<TableData[]> and manually calling next on each vm$ update, you could expose an observable data source and bind to it directly in the template (e.g., via async pipe), which would simplify the component and reduce state duplication.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- You now have multiple subscriptions to `vm$` in `SampleDetailComponent` that each handle different concerns (attachments, table data, pagination); consider consolidating these into a single subscription or using `tap` in the selector to reduce duplicate subscription logic and make state updates easier to reason about.
- Instead of maintaining a `BehaviorSubject<TableData[]>` and manually calling `next` on each `vm$` update, you could expose an observable data source and bind to it directly in the template (e.g., via `async` pipe), which would simplify the component and reduce state duplication.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Junjiequan]

It seems that the table has fixed height? can we make it consistant with dataset table and proposal table

[Junjiequan]

Just tested PR locally and I see the error below,
To replicate, open any sample detail view

[Junjiequan]

Could you confirm JsonHeadPipe is needed

[abdimo101]

It is needed because after adding the datasetsListService.convertSavedDatasetColumns in sample-detail.component, it throws this:

[abdimo101]

It seems that the table has fixed height? can we make it consistant with dataset table and proposal table

Fixed height has been removed in another PR since I believe is more relevant to do it there 14f0469

[Junjiequan]

lgtm