[Performance] Optimize unstyled utility#7626
Conversation
Add an early return to the `unstyled` function in `packages/cli-kit/src/public/node/output.ts` to skip ANSI stripping for strings that don't contain the ESC character (`\u001b`). This avoids expensive regex execution for plain strings, which is a common case in terminal layout and logging paths.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
unstyledutility is used frequently in CLI operations, especially during logging and terminal layout calculations. The underlyingstripAnsifunction uses a complex regular expression that can be computationally expensive when called repeatedly on plain strings.WHAT is this pull request doing?
Optimizes the
unstyledfunction inpackages/cli-kit/src/public/node/output.tsby adding an early return:if (!message.includes('\u001b')) return message. This avoids the regex overhead for any string that doesn't contain ANSI escape codes.How to test your changes?
CI
Post-release steps
None
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 6608015497183229439 started by @gonzaloriestra