helpers: raise default HTTP request timeout from 1s to 10s#1323
Open
mbouaziz wants to merge 1 commit into
Open
helpers: raise default HTTP request timeout from 1s to 10s#1323mbouaziz wants to merge 1 commit into
mbouaziz wants to merge 1 commit into
Conversation
fetchJSON and SkipServiceBroker aborted requests after 1 second by default. On a loaded CI executor that window is too tight: in the skipruntime-bun job, the database example's PUT (express -> SQLite -> broker update against the Skip control service) exceeded it and the client died with a TimeoutError, failing the job. The broker's own calls carry the same 1s bound, so a slow service turns into spurious 500s server-side too. Default both to a shared 10s constant: generous enough not to give up on a slow service, while still bounding how long requests can hang. Callers can still pass an explicit timeout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
skipruntime-bunjob on #1321 failed in thedatabaseexample: the client's PUT died with aTimeoutErrorand the run lost its remaining expected output. The failure is unrelated to that PR (the example is SQLite-based; the job's Postgres tests passed) — it's the example harness being flaky on a loaded executor.fetchJSONandSkipServiceBrokerabort requests after 1 second by default. The example client's PUT traverses express → SQLite → broker update against the Skip control service; under Bun running from source on a busy CI machine that round trip can exceed 1s, killing the client. The broker's own calls carry the same 1s bound, so the same slowness can surface as spurious 500s server-side.This bumps both defaults to a shared 10s constant — generous enough not to give up on a slow service, while still bounding how long requests can hang. Callers can still pass an explicit
timeout. Doc references to the default (includingPolledHTTPResource.options, which forwards tofetchJSON) are updated to match.🤖 Generated with Claude Code