Cherry-pick Yoga UDL fix for beta-0.1.1#111
Open
clholgat wants to merge 1 commit into
Open
Conversation
Newer Clang versions treat `operator"" _pt` (with space) as -Werror,-Wdeprecated-literal-operator. Remove the space so it compiles cleanly: `operator""_pt`. Cherry-picked from main (1c6d740).
Sensitive Files Detected🧘 Yoga layout engine — HIGH blast radius — affects all layout. Verify layout tests exist and pass. This is an automated notice. A maintainer will review after import. |
📊 PR Size: size/STotal changes: 12 lines (1 files) Top files changed:
Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+) |
|
| Test Suite | Result |
|---|---|
| Valdi Smoke Tests | ❌ failure |
| Snapshot Tests | ✅ success |
| Linux: Build & Export | ✅ success |
| Linux: C++ Tests | ✅ success |
Some tests failed. Please check the workflow logs for details.
🚀 Bazel remote cache is now enabled - future builds will be faster!
Workflow: Valdi CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick the Yoga
YGValue.hUDL syntax fix frommain(1c6d7408) to the release branch.Newer Clang versions (shipped with recent macOS GitHub Actions runners) treat
operator"" _pt(with space before the suffix) as-Werror,-Wdeprecated-literal-operator. This removes the space so it compiles cleanly.This was breaking:
Test Plan
CI on this PR should pass. After merge,
beta-0.1.1will be retagged at the new branch head.