-
Notifications
You must be signed in to change notification settings - Fork 0
Improve fragmentation package test coverage
#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Vladyslav-Kuksiuk
merged 5 commits into
master
from
improve-fragmentation-test-coverage
Jul 13, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| * Copyright 2026, TeamDev. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Redistribution and use in source and/or binary forms, with or without | ||
| * modification, must retain the above copyright notice and the following | ||
| * disclaimer. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| //nolint:testpackage // Covers package-private filesystem hooks used for deterministic errors. | ||
| package files | ||
|
|
||
| import ( | ||
| "errors" | ||
| "os" | ||
| "path/filepath" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| var _ = Describe("Files internals", func() { | ||
| It("should treat a path removed after glob resolution as missing", func() { | ||
| filePath := writeTemporaryFile() | ||
|
|
||
| withStatError(os.ErrNotExist, func() { | ||
| exists, err := IsFileExist(filePath) | ||
|
|
||
| Expect(err).ShouldNot(HaveOccurred()) | ||
| Expect(exists).Should(BeFalse()) | ||
| }) | ||
| }) | ||
|
|
||
| It("should report stat errors after glob resolution", func() { | ||
| filePath := writeTemporaryFile() | ||
| statErr := errors.New("stat failed") | ||
|
|
||
| withStatError(statErr, func() { | ||
| exists, err := IsFileExist(filePath) | ||
|
|
||
| Expect(exists).Should(BeFalse()) | ||
| Expect(err).Should(MatchError(statErr)) | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| // withStatError replaces path inspection with a deterministic error. | ||
| func withStatError(statErr error, action func()) { | ||
| originalStatPath := statPath | ||
| statPath = func(_ string) (os.FileInfo, error) { | ||
| return nil, statErr | ||
| } | ||
| defer func() { | ||
| statPath = originalStatPath | ||
| }() | ||
|
|
||
| action() | ||
| } | ||
|
|
||
| // writeTemporaryFile creates an existing path for glob resolution. | ||
| func writeTemporaryFile() string { | ||
| filePath := filepath.Join(GinkgoT().TempDir(), "file.txt") | ||
| Expect(os.WriteFile(filePath, []byte("content"), os.FileMode(WritePermission))).To(Succeed()) | ||
|
|
||
| return filePath | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor / design: this (and
makeAbsolutePathinfragmentation.go:63) introduces a mutable package-global into production code purely as a test seam. It works and is well-documented, and since Ginkgo parallelism is process-based the global mutation is safe. Just flagging the tradeoff for the record — an alternative that keeps production surface immutable would be injecting the stat/abs function through the existing struct (e.g.Resolver/Fragmentation) rather than a reassignable global. Not blocking.