fix: skip empty getOption values in Autoresponder hook#311
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
$mailFrom, $mailSender, and $mailFromName fell back to an empty string instead of the default when fiarFrom/fiarSender/fiarFromName existed in the properties but were empty, which could cause the auto-responder email to fail to send. Pass true as the fourth getOption() argument so empty values are skipped in favor of the default. Fixes Sterc#282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getOption()calls forfiarFrom,fiarSender, andfiarFromNamearound line 79 ofAutoresponder.phpdidn't skip empty values, so an empty property fell through instead of using the default. That could cause the auto-responder email to fail to send.Adds
trueas the fourth argument to those threegetOption()calls, matching the existing pattern already used a few lines above forfiarTpl.Fixes #282