Add a Source View button to the main toolbar#11608
Merged
niksedk merged 2 commits intoJun 15, 2026
Merged
Conversation
Source View existed only as a command (no toolbar entry), so the toggle button users had in SE4 was missing. Add a toolbar button - using the existing SourceView theme icon - that runs ShowSourceViewCommand, gated by a new ToolbarShowSourceView appearance flag (default on) with a matching "Show source view icon" checkbox in Settings > Appearance.
Member
|
No new language tags for now, so this must wait |
Member
|
Also, is the default value false? |
- Default ToolbarShowSourceView to false so the toolbar is unchanged for
existing users unless they opt in.
- Drop the new language tags (SourceViewHint, ShowToolbarSourceView) and reuse
the existing Options.Shortcuts.SourceView ("Source view") string for both the
toolbar tooltip/automation name and the settings checkbox, so no new
translation tags are introduced.
Author
|
Thanks - addressed both:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11605
Source View only existed as a command in SE5 (no toolbar entry), so the toggle button from SE4 was missing.
SourceViewtheme icon that runsShowSourceViewCommand.ToolbarShowSourceViewappearance flag (default on) with a matching "Show source view icon" checkbox in Settings > Appearance, like the other toolbar icons.Builds clean (0/0). Test build provided so the icon/placement can be checked.