[codex] Fix Fade visuals and map rotation#79
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Valorant content/config and release metadata to reflect a new app version, including a visual fix for Fade’s Haunt radius and an updated map rotation.
Changes:
- Bump app version to
4.3.5+89(including desktopmsix_version) and add matching desktop release metadata. - Fix Fade’s Haunt scan radius rendering by removing the
opacity: 0override. - Update map rotation: move Ascent into rotation and Bind out of rotation.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| release/metadata/4.3.5+89.json | Adds desktop release metadata for version 4.3.5+89. |
| pubspec.yaml | Bumps Flutter app version and MSIX version. |
| lib/const/settings.dart | Updates in-app version constants to 4.3.5 / 89. |
| lib/const/maps.dart | Swaps Ascent/Bind between in-rotation and out-of-play lists. |
| lib/const/agents.dart | Makes Fade’s Haunt radius visible by removing opacity: 0. |
| AGENTS.md | Removes the agent/contributor instructions document. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| publish_to: "none" # Remove this line if you wish to publish to pub.dev | ||
|
|
||
| version: 4.3.4+88 #version number | ||
| version: 4.3.5+89 #version number |
Greptile SummaryThis PR fixes two Fade visual bugs (stale icon asset and invisible scan-radius circle caused by
Confidence Score: 4/5The code changes are safe to merge; the only item that warrants a second look is AGENTS.md being fully emptied. The dart and YAML changes are small, targeted, and internally consistent — opacity removal, map swap, and version bump all match their stated intent. The one open question is AGENTS.md: all developer workflow guidance (FVM pin, build deps, code-gen steps, lint baseline) was removed with no redirect or explanation, which could silently break onboarding for future contributors and AI tooling that reads the file before making changes. AGENTS.md — all content was removed; worth confirming the guidance was intentionally retired or moved elsewhere before merging. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Fade AgentData] --> B[abilities[1] CircleAbility\nsize: 6.58, opacity: null]
A --> C[abilities[2] CircleAbility\nsize: 30, opacity: null\n✅ was opacity:0]
A --> D[abilities.last SquareAbility]
E[Maps.availableMaps] --> F[ascent ✅ was bind]
E --> G[haven, pearl, split,\nbreeze, lotus, fracture]
H[Maps.outofplayMaps] --> I[bind ✅ was ascent]
H --> J[sunset, abyss,\nicebox, corrode]
|
Summary
4.3.5+89and add matching desktop release metadata.Root Cause
opacity: 0, so the radius rendered invisible.icon.webpasset was stale.Validation
fvm dart format lib\const\agents.dart lib\const\maps.dart lib\const\settings.dart.scripts\generate_update_manifest.ps1against a temp output path and confirmed4.3.5+89appears first withshortVersion89.fvm flutter analyze; it completed with 4 existingprefer_const_constructorsinfos intest\square_icon_counter_rotation_test.dartand no new errors.