Skip to content

Bulk multibyte#4626

Open
SuuperW wants to merge 5 commits into
masterfrom
bulk_multibyte
Open

Bulk multibyte#4626
SuuperW wants to merge 5 commits into
masterfrom
bulk_multibyte

Conversation

@SuuperW

@SuuperW SuuperW commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

To enable bulk poke/peek access for 16 and 32 bit values, I have given MemoryDomain , IMemoryApi, and MemoryLuaLibrary some new functions.

Check if completed:

@YoshiRulz YoshiRulz mentioned this pull request Feb 12, 2026
2 tasks
YoshiRulz

This comment was marked as outdated.

@SuuperW

SuuperW commented Feb 22, 2026

Copy link
Copy Markdown
Contributor Author

Regarding all of your comments about being able to just convert between bulk byte and bulk int reads: No. The only reason I made this is to support #4555. The core MUST know what size we are reading, and the various sized reads cannot simply be re-interpreted as another.

@vadosnaprimer

Copy link
Copy Markdown
Contributor

Conflicts appeared, but also it's unclear from the discussion if there's anything else that has to change still.

@SuuperW

SuuperW commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

I was going to wait for Yoshi to finish #3965 but I can go ahead and fix some stuff here in a few days.

@vadosnaprimer

Copy link
Copy Markdown
Contributor

I was going to wait for Yoshi to finish #3965

That one looks like it will require 20 more years to get done abandoned forever.

@SuuperW

This comment was marked as outdated.

Comment thread src/BizHawk.Tests.Client.Common/Api/MemoryApiTests.cs Outdated
@SuuperW

SuuperW commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

Updated so that existing methods in IMemoryApi are not changed. New methods are added instead. Tests are updated accordingly, and I have also added some basic tests for the Lua API.

The failing builds are for .NET Core where MA0089 wants me to use an overload that does not exist in .NET Framework. Perhaps we should disable this rule. I don't know if it can be disabled only for .NET Core builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants