Feature/ad and adbreak custom data bridging#866
Open
wvanhaevre wants to merge 9 commits into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: william.vanhaevre <william.vanhaevre@dolby.com>
Co-Authored-By: william.vanhaevre <william.vanhaevre@dolby.com>
KSHITIZ6341
reviewed
Jul 9, 2026
| } | ||
| adPayload.putArray(PROP_AD_WRAPPER_CREATIVE_IDS, wrapperCreativeIdsPayload) | ||
| } | ||
| val customData = ad.customData |
There was a problem hiding this comment.
Could we add coverage for null values inside customData on Android? This path goes through BridgeUtils.fromJSONObjectToBridge, and that converter currently skips JSONObject.NULL object values and skips null array entries entirely. That means a payload like {"foo": null} would lose foo, and [1, null, 2] would be compacted before JS sees it.
If customData is meant to preserve integration-provided JSON shape, I think the converter should call putNull(key) / pushNull() for JSONObject.NULL, with a small Ad or AdBreak regression test to lock that in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.