Separate integration tests by JUnit version#1636
Open
schulzjo-tng wants to merge 1 commit into
Open
Conversation
schulzjo-tng
force-pushed
the
feature/restructure-integration-tests
branch
3 times, most recently
from
48d5bc0 to
806127c
Compare
Signed-off-by: Dr. Jonathan Schulz <jonathan.schulz@tngtech.com>
schulzjo-tng
force-pushed
the
feature/restructure-integration-tests
branch
from
806127c to
3e52e73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for adding JUnit 6 support. Since JUnit 5 and JUnit 6 have a lot of overlap in their classes, it is not possible (or, at the very least, not easy or clean) to integration test both JUnit 5 and JUnit 6 from the same Gradle subproject.
I split the shared configuration because the explicit dependencies on JUnit 5 would leak into the integration test classpaths.
I decided against removing all JUnit 5 code from the JUnit 4 integration test since I considered that to be too much effort for a JUnit version that has been deprecated for quite a while now.