feat(datagrid): redesign filter panel header and row actions#1649
Open
J2TeamNNL wants to merge 1 commit into
Open
feat(datagrid): redesign filter panel header and row actions#1649J2TeamNNL wants to merge 1 commit into
J2TeamNNL wants to merge 1 commit into
Conversation
- Rename 'Unset' -> 'Clear': calls clearAppliedFilters() (keeps rows, returns to unfiltered); old clearFilterState() moved to 'Remove All Filters' in ... menu - Remove per-row Apply/Applied buttons; 'Apply Only This Filter' added to row context menu via rightMouseDown - Tri-state checkbox in header toggles all filter rows enabled/disabled at once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Implements the new filter panel interaction model:
Clear vs Remove All
clearAppliedFilters()— keeps all filter rows, just removes the applied state so the table returns to unfiltered results....options menu: callsclearFilterState()— removes all filter rows entirely.Per-row Apply moved to context menu
applySoloFilterpath).Tri-state toggle-all checkbox
checkmark.square.fill/square/minus.square.fill) added to the filter panel header.Files:
TablePro/Views/Filter/FilterPanelView.swift,TablePro/Views/Filter/FilterRowView.swiftTest plan
...menu > "Remove All Filters" — all rows removed, table reloads unfiltered