Add theming support and other changes.#99
Open
AllanWang wants to merge 3 commits into
Open
Conversation
roke-julian-lockhart
suggested changes
Aug 1, 2022
There was a problem hiding this comment.
"http://github.com/Tasssadar/MultiROMMgr/issues/114" is superior to your colourative improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main point of this commit was to move all hardcoded colors to the color.xml
However, the ones in html (and strings) are not changed, as I don't know how.
Also, I updated your gitignore to ignore gen/, .idea, and .iml files among other things. Those should not be uploaded to git and may cause errors if you pull from someone else's build.
The app built for me, but with the git changes, hopefully it will work for you as well.
Thanks!