Fix ParseNumber integer parse bug around max int32 and uint32.#2382
Open
NonRadical wants to merge 1 commit into
Open
Fix ParseNumber integer parse bug around max int32 and uint32.#2382NonRadical wants to merge 1 commit into
NonRadical wants to merge 1 commit into
Conversation
For a range of integers around max int32 and uint32, the current implementation can "miss" that the accumulated integer will overflow due to the evaluation of the potential overflow happening before the accumulation is done. Example values that experience this issue are 4,294,967,296 (max uint32 + 1) and 2,147,483,648 (max int32 + 1).
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For integers in a range above from and including max int32 as well as a range down from and including max uint32, the current implementation of ParseNumber can "miss" that the accumulated 32 bit integer will overflow due to the evaluation of the potential overflow happening before the accumulation is done. Example values that experience this issue are 2,147,483,648 (max int32) and 4,294,967,295 (max uint32).