Apply SHOW_LIBRARIES config to child mods#1039
Merged
Merged
Conversation
Contributor
|
I'll merge this to the head branch and then backport (so expect a rebase in a moment). edit 1: Oh boy, GH decided to be weird about that rebase. I'll merge and then figure out if I need to fix anything I guess... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per this report in the Terraformers Discord, when the config
SHOW_LIBRARIESis set tofalse("Libraries: Hidden"), libraries are still shown when they are child mods.This PR simply duplicates the check used for parent mods to also check child mods.
This should be cherry-picked to other maintenance branches (specifically, 26.2) if approved.