More CI related stuff#739
Open
StaticRocket wants to merge 6 commits into
Open
Conversation
We can avoid running this entirely if none of the files we're looking for have been modified. I wish we could use a yaml anchor or something to prevent duplicating the patterns here, but it doesn't seem like that's an option as the other workflow only wants strings. Signed-off-by: Randolph Sapp <rs@ti.com>
As much as I liked the simplicity in the old workflow definition, it had issues when pushing container updates in combination with source updates. The docker and build workflows would race. Needs explicit checks for "!failure() && !cancelled()" because once one thing in a needs chain is unsatisfied (or skipped) GitHub would prefere to invalidate the entire chain. Signed-off-by: Randolph Sapp <rs@ti.com>
Well, version pinning requires inline comments that frequently make lines go over the recommended 80 character length. Disable this check for all the workflow files preemptively. Signed-off-by: Randolph Sapp <rs@ti.com>
It's generally advised to pin workflow versions to avoid issues with floating tags or manipulated releases. Dependabot can still track and upgrade things if we add inline comments. Signed-off-by: Randolph Sapp <rs@ti.com>
Work around an upstream issue [1] with a manual pin for now. Hopefully this won't break future dependabot checks. [1] vale-cli/vale-action#158 Signed-off-by: Randolph Sapp <rs@ti.com>
Apparently you can ignore a cancel request with the always() function. This is only documented on a single page in the GitHub workflow docs that I found in passing checking other garbage. I assume this means you could also bypass concurrency flags with this in place. Don't really want to find out. Signed-off-by: Randolph Sapp <rs@ti.com>
StaticRocket
requested review from
VeeruPrudhvi,
cshilwant,
gehariprasath,
jeevantelukula,
praneethbajjuri and
uditkumarti
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good news. Hopefully this can be a reference for how to use workflows somewhat correctly now. All issues I can find have been addressed. Bad news is, vale might cause us some issues when the next dependabot update comes around. We'll deal with that later. Need to get it back up and running for now.
ci: use !cancelled() instead of always()
Apparently you can ignore a cancel request with the always() function. This is
only documented on a single page in the GitHub workflow docs that I found in
passing checking other garbage.
I assume this means you could also bypass concurrency flags with this in
place. Don't really want to find out.
Signed-off-by: Randolph Sapp rs@ti.com
ci(vale): work around vale-action issue
Work around an upstream issue [1] with a manual pin for now. Hopefully this
won't break future dependabot checks.
[1] Release named v2.1.2 points to tag named 2.1.2 vale-cli/vale-action#158
Signed-off-by: Randolph Sapp rs@ti.com
ci: pin all workflows
It's generally advised to pin workflow versions to avoid issues with floating
tags or manipulated releases. Dependabot can still track and upgrade things if
we add inline comments.
Signed-off-by: Randolph Sapp rs@ti.com
ci: yamllint disable max line length check
Well, version pinning requires inline comments that frequently make lines go
over the recommended 80 character length. Disable this check for all the
workflow files preemptively.
Signed-off-by: Randolph Sapp rs@ti.com
ci(build): merge the docker and build workflow
As much as I liked the simplicity in the old workflow definition, it had
issues when pushing container updates in combination with source updates. The
docker and build workflows would race.
Needs explicit checks for "!failure() && !cancelled()" because once one thing
in a needs chain is unsatisfied (or skipped) GitHub would prefere to
invalidate the entire chain.
Signed-off-by: Randolph Sapp rs@ti.com
ci(vale): restrict paths
We can avoid running this entirely if none of the files we're looking for have
been modified. I wish we could use a yaml anchor or something to prevent
duplicating the patterns here, but it doesn't seem like that's an option as
the other workflow only wants strings.
Signed-off-by: Randolph Sapp rs@ti.com