drt allows for spacing 0 between metal and blockage#10856
Open
bnmfw wants to merge 5 commits into
Open
Conversation
Signed-off-by: bnmfw <bernardoborgessandoval@gmail.com>
Signed-off-by: bnmfw <bernardoborgessandoval@gmail.com>
Parse and store the SPACING value from macro OBS layer geometry sections (lefiGeomLayerMinSpacingE). Previously this was a FIXME no-op. The value is stored on dbBox::min_spacing_ and propagated through frBlockage to DRT's GC checker, where it overrides the spacing table lookup for blockage shapes. This enables SPACING 0 in macro OBS sections to suppress false short violations between routing and cell obstructions on layers that only have LEF58 spacing rules (e.g. Rapidus2HP M5). Signed-off-by: bnmfw <bernardoborgessandoval@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for minimum spacing (minSpacing) in dbBox, frBlockage, gcNet, and the LEF parser, including database schema updates to serialize the new min_spacing_ field. It also updates the metal spacing check logic to handle abutting rectangles via a new parameter. The review feedback recommends correcting the spelling of the parameter rects_abute to rects_abut (or rects_abutting) across its declaration, definition, and usages, as well as simplifying the parameter type from const bool to bool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OBS LEF
SPACINGModifier is now understood by the ODB and DRT. DRT allows abutting of metal to blockage without raising shorts if the blockage hasSPACING 0.OBD and Lefin Changes
Essentially
min_spacingwas added to behave just likedesign_rule_width. Modifications ingcNet.h,frBlockage.h,io.cpp,db.h,lefin.cpp,dbBox.handdbBox.cppare made to mimic the behavior of the former implemented modifier.dbDatabase.hwas changed to update the DB version. Some modifications onFlexGC_main.cppare also implementations ofmin_spacingSPACING 0 Means allowing abutting
rects_abutewas added. If we are in a short but eitherprlis 0, it means that the intersection area is 0, only abutting is happening, so the flag is set to true. Further, ifcheckMetalSpacing_prl_getReqSpcValreturns 0, than the spacing required is 0, so there is no DRV, meaning an early return.Type of Change
Impact
Changes ODB minor verstion.
Allows for reading and usage of the
SPACINGmodifier on OBS LEFAllows Abutting of metal to blockage without causing shorts if said blockage has spacing 0
Verification
./etc/Build.sh).Related Issues
Makes Progress torwards #1701
The issue is not solved, another pin access problem is raised but has a different cause.