Move ToStreamBuilder's container builder to method generic#792
Merged
frankmcsherry merged 2 commits intoMay 28, 2026
Merged
Conversation
Generic-over-Item trait with method-level CB enables method-call syntax `(0..3).to_stream_with_builder::<_, CB>(scope)` instead of the UFCS form `ToStreamBuilder::<CB>::to_stream_with_builder(...)`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Per review feedback: each implementor of `ToStreamBuilder` has exactly one item type (`I::Item` for the blanket impl), so an associated type fits better than a trait-level generic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic-over-
Itemtrait with method-levelCBenables method-call syntax(0..3).to_stream_with_builder::<_, CB>(scope)instead of the UFCS formToStreamBuilder::<CB>::to_stream_with_builder(...).Breaking change to a public trait signature; CHANGELOG updated. Version bump handled separately.