Correct soundness hole, add Sync bound#800
Merged
frankmcsherry merged 1 commit intoMay 28, 2026
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Byteshad a soundness hole, that you could constructBytesMutwith aB: !Send, then convert to aBytesand send it around (theBtype has been erased by this point). The fix is to insist onB: Sendin the constructor forBytesMut, which is the only way to form one of these.At the same time, add a
Syncimplementation (Claude is quite sure thatB: Syncis not necessary; the doccomment explains the reasoning; bit of a risk if anyone adds methods that allow access to&Bbut .. no plans to do this).