fix: prune only matching release asset versions - #471
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe R2 release asset prune planner gains a stricter asset-selection predicate: it now imports ChangesR2 Prune Planner — Version-Match Filter
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
建议增加 tag/channel 边界测试。 Please add tag/channel edge-case tests. |
|
This pull request has been inactive for 21 days. Please update it or leave a note if it is still in progress. |
Summary
Fixes the R2 release asset prune planner so it only deletes download assets whose file version exactly matches the stale GitHub release tag. This prevents a newer same-channel asset from being pruned if it is attached to an older release by mistake.
Related issue or RFC
Related to https://github.com/TouchAI-org/TouchAI release asset retention workflow.
AI assistance disclosure
Testing evidence
Targeted local checks passed:
I did not run the full
pnpm test:prsuite locally because the change is limited to the release pruning script and its targeted regression test; CI should provide the full-suite proof.TDD: regression case added with the fix to cover the unsafe prune scenario.
Risk notes
AgentService, runtime, MCP, or schema impact: none.Screenshots or recordings
Not applicable; no UI changes.
Checklist
[WIP]or similar title prefixes.AgentService, runtime, MCP, or schema boundaries, there is an accepted RFC.pnpm test:prfor this code PR, or this is a docs-only change.pnpm test:coverage:rustor relied on CI coverage evidence.pnpm test:e2elocally or documented why CI is the first valid proof.