Feat/ordering#15
Merged
Merged
Conversation
matejstastny
left a comment
matejstastny
left a comment
Member
There was a problem hiding this comment.
Very nice, I have some suggestions:
- The orders page should include the ammount of money left in the buckets on top
- Sorting and filtering would be nice
- Editing orders to be submitted for rereview or deleting not approved orders (if accidentaly submitted)
RadAlpaca11
approved these changes
Jun 15, 2026
RadAlpaca11
left a comment
RadAlpaca11
left a comment
Member
There was a problem hiding this comment.
Looks good to me!
A super nitpicky and likely unnecessary thing is that I got a bit confused on what the vendor would be if it was amazon, so there could be something noted there, but honestly it's not that big of a deal.
Member
|
Looks good enough to me. I still don't like some things in the layout, but we cannot get stuck on small things. If it is going to be a big issue, we will polish it later when in use. Merging! 💫 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Revamped the ordering workbook.
Added a new finance tab to manage buckets and STF quarters. Revamped the ordering queue and the order requests to include design doc specs.
Why
Ordering right now is a mess, this makes our lives easier.
Type of change
feat/)fix/)chore/)docs/)refactor/)Checklist
pnpm lintpassespnpm format:checkpassesschema.tswas changed - migration generated (pnpm db:generate) and committed alongside the schema