Fix uxarray CI link-check failure#1584
Conversation
|
@erogluorhan @cmdupuis3 I believe this fixes the link-check issue, and that our nightly uxarray ci would no longer crash if we merge this. Slight complication: I commented out the "#if: github.event_name != 'pull_request'" rule for this branch so that the link check would actually run here, instead of being skipped. If I push another commit restoring that rule, the bot will rerun checks without link-check, so you won't actually be able to see that tests pass…. My recommendation: take a look, leave review saying it looks good but request change: that line needs to be un-commented before merging. Once we have two "looks good but please un-comment that line" reviews, we can fix it, then the reviewers can approve, then we can merge. Alternatively, if there is a way to "force run" link-check on this branch, even while that line exists, maybe we could do that instead? I'm not sure how to do that though, please go for it if you know how. |
erogluorhan
left a comment
There was a problem hiding this comment.
The URL fix seems good to me! Please go ahead and revert the commented out part in the workflow, and I'll approve this after that.
I don't think there is a better way to tell link-check to run in this case because of how we wrote it (i.e. closes all doors to it when it is a PR).
cmdupuis3
left a comment
There was a problem hiding this comment.
Just waiting on the comment removal
Address uxarray ci failing due to link-check; see #1580. Does not yet address the upstream-ci failure.
Overview
The healpix paper link (https://iopscience.iop.org/article/10.1086/427976) started failing recently for github ci. Replaced with doi link (https://doi.org/10.1086/427976). This might be enough to fix the broken link check?
Note: make sure to un-comment commented part of workflow before merging (maybe there was a more elegant way to tell link-check to run on this PR)?
PR Checklist
General