Fix/misalignment qa housekeeping#114
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After merging Misalignment QA use case there were a few things that needed refactoring just to remain consistent with the rest of the codebase. No significant changes.
Clickup Ticket(s): Link(s) if applicable.
Type of Change
Changes Made
analysis.py) from the library package toimplementations/misalignment_qa/, where they are used02_inspect_results.ipynbto import from the new locationMisalignmentTaskagent parameter type fromAnytoLlmAgentload_dotenv()fromrun_experiment_config()to the CLI entrypoint (evaluate.py)Testing
uv run pytest tests/)uv run mypy <src_dir>)uv run ruff check src_dir/)Manual testing details:
uv run python implementations/misalignment_qa/evaluate.py --config implementations/misalignment_qa/configs/bootcamp_misalignment.yaml --variant-id <one-variant>from repo root02_inspect_results.ipynb; confirmMisalignmentResultsExplorerimports correctlyGOOGLE_API_KEY, Langfuse keys) are still picked up when running via CLIChecklist