[VPD 1241] Certik: Venus Labs - Core Feature Reaudit#315
Open
GitGuru7 wants to merge 12 commits into
Open
Conversation
…ot upheld by the cache logic in the derivation bounder oracle
…ion, allowing silent cap-disable or price DoS
|
Debugger022
reviewed
Jun 23, 2026
| function setSnapshot(uint256 _snapshotMaxExchangeRate, uint256 _snapshotTimestamp) external { | ||
| _checkAccessAllowed("setSnapshot(uint256,uint256)"); | ||
|
|
||
| if (snapshotInterval != 0) { |
Contributor
There was a problem hiding this comment.
better to have same validation in setGrowthRate (against the stored snapshot) when interval goes 0 → non-zero,
Contributor
Author
There was a problem hiding this comment.
Yes, that would be better. However, we already have the final audit report, and in practice we wouldn't set the values to 0 anyway. So, I think we can include this change the next time the contract goes through an audit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #
Checklist