operator: add VPA support to vmalert, vmalertmanager, vmagent, vlagent, vlsingle, vtsingle, vmsingle#2285
Open
AndrewChubatiuk wants to merge 1 commit into
Open
operator: add VPA support to vmalert, vmalertmanager, vmagent, vlagent, vlsingle, vtsingle, vmsingle#2285AndrewChubatiuk wants to merge 1 commit into
AndrewChubatiuk wants to merge 1 commit into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 20 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
AndrewChubatiuk
force-pushed
the
vpa-support
branch
from
c1b28ac to
20531ec
Compare
vrutkovs
reviewed
Jun 15, 2026
Contributor
There was a problem hiding this comment.
1 issue found across 20 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
AndrewChubatiuk
force-pushed
the
vpa-support
branch
3 times, most recently
from
1e0fc93 to
90e635c
Compare
vrutkovs
reviewed
Jun 15, 2026
AndrewChubatiuk
force-pushed
the
vpa-support
branch
2 times, most recently
from
d842f1a to
78fe37c
Compare
vrutkovs
reviewed
Jun 25, 2026
vrutkovs
left a comment
vrutkovs
left a comment
Collaborator
There was a problem hiding this comment.
generally looks good, vlagent needs a few fixes
| return fmt.Errorf("remoteWrite.tlsConfig has incorrect syntax at idx: %d: %w", idx, err) | ||
| } | ||
| } | ||
| if cr.Spec.VPA != nil { |
Collaborator
There was a problem hiding this comment.
We need to reject k8sCollector / daemonset mode - VPA doesn't support these
| if cr.Spec.PodDisruptionBudget == nil { | ||
| objsToRemove = append(objsToRemove, &policyv1.PodDisruptionBudget{ObjectMeta: objMeta}) | ||
| } | ||
| if config.MustGetBaseConfig().VPAAPIEnabled && cr.Spec.VPA == nil { |
Collaborator
There was a problem hiding this comment.
We should remove VPAs when we switch to k8scollect mode too
AndrewChubatiuk
force-pushed
the
vpa-support
branch
from
78fe37c to
b2bfea2
Compare
…t, vlsingle, vtsingle, vmsingle
AndrewChubatiuk
force-pushed
the
vpa-support
branch
from
b2bfea2 to
152c4cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2252
Summary by cubic
Add VerticalPodAutoscaler support via a new spec.vpa field for vmagent, vmalert, vmalertmanager, vmsingle, vlsingle, vtsingle, vlagent, and vmanomaly. The operator now creates, updates, and deletes VPAs for these resources; enable with VM_VPA_API_ENABLED=true.
New Features
Migration
Written for commit 78fe37c. Summary will update on new commits.