Enable fuzzing for wide arithmetic#8781
Merged
Merged
Conversation
stevenfontanella
force-pushed
the
enable-wide-arithmetic-fuzz
branch
from
7465c0e to
deda835
Compare
stevenfontanella
added a commit
that referenced
this pull request
May 27, 2026
Part of #8544. Continued in #8781. Drive-by fix: ensure that tuples aren't generated with a size larger than TUPLE_MAX_SIZE: ```diff - size_t maxElements = 2 + upTo(fuzzParams->MAX_TUPLE_SIZE - 1); + size_t maxElements = 2 + upTo(fuzzParams->MAX_TUPLE_SIZE - 2); ``` After increasing the seed file size, the wide arithmetic instructions [were generated](https://github.com/WebAssembly/binaryen/actions/runs/26316945566/job/77478064626) (ctrl + f "wideint"), but fails in CI due to #8770. For now I leave the seed file unchanged without showing that the wide arithmetic instructions are generated in the golden file. Also generated a new seed for test/lit/fuzz-import.wast since it was failing after these changes, seemingly due to bad luck (which the test file mentions is a possibility).
stevenfontanella
force-pushed
the
enable-wide-arithmetic-fuzz
branch
from
deda835 to
d03b102
Compare
Member
Author
|
Will run the fuzzer for a few hours before submitting. Currently at ~4k iterations with no issues. |
kripken
approved these changes
May 27, 2026
Member
Author
|
Ran 6500 iterations with no issue. FWIW there may be some bugs in the V8 implementation that we might hit: https://issues.chromium.org/issues/514906333#comment9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8544, continued from #8661. The V8 implementation is ready now under an experimental flag.