Spng#489
Open
brettviren wants to merge 460 commits into
Open
Conversation
…ay have to remove if c++ components get angry
…ed to 'apply roi'
…nctionality of this simple function.
…nfig. See tdm.jsonnet comments for detail
…c.us for electron lifetime. Sigh.
Configure U/V with wiener+tight_lf. Results still not good
…om line depo sims. Consider adding a config parameter for variations
…o output -- reflected in Snakefile
…onnet which calls TorchService for the OSP option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the "spng" branch after recent "master" was merged into it and the tests and doctests pass. It provides Signal Processing, Next Generation based on re-writing OmnibusSigProc into a Torch-based, more fine-grained set of components that keep data in Torch tensor form on the GPU (or CPU) as it passes between nodes.
Most of the work is in the
spng/directory but various improvements have been added toutil/. These were done with care not to change behavior for others and given the tests pass, I think they should be mostly safe to accept, but some review is needed.