feat: Add an invariant to ensure object deletion also deletes its pseudo-account by Tapanito · Pull Request #7445 · XRPLF/rippled

Tapanito · 2026-06-10T13:19:52Z

Overview

Ensures that when a ledger object with an associated pseudo-account (AMM, Vault, LoanBroker) is deleted, its pseudo-account is also deleted.

High Level Overview of Change

The ObjectHasPseudoAccount invariant checks: object deleted → pseudo-account deleted.

Together with the existing AccountRootsDeletedClean invariant (which checks the reverse: pseudo-account deleted → object deleted), these two invariants guarantee that an object and its pseudo-account are always deleted as a pair.

Context of Change

Previously, the only invariant enforcement was one-directional: AccountRootsDeletedClean ensured that deleting a pseudo-account also deleted the linked object (via getPseudoAccountFields()). The reverse direction — deleting the object must also delete the pseudo-account — was only enforced by convention in transactor code.

This PR closes the gap by adding the complementary check.

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

xrplf-ai-reviewer

Gave this a review

Two correctness issues: implicit fallthrough drops sle_ on match, and the single-pointer field silently ignores all but the last matching object per transaction — see inline comments.

Review by ReviewBot 🤖

Review by Claude Sonnet 4.6 · Prompt: V15

codecov · 2026-06-10T14:08:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (ecf7f80) to head (3c7d214).

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #7445   +/-   ##
=======================================
  Coverage     82.3%   82.3%           
=======================================
  Files         1024    1024           
  Lines        78397   78423   +26     
  Branches      8973    8973           
=======================================
+ Hits         64514   64545   +31     
+ Misses       13874   13869    -5     
  Partials         9       9

Files with missing lines	Coverage Δ
include/xrpl/tx/invariants/InvariantCheck.h	`100.0% <ø> (ø)`
src/libxrpl/tx/invariants/InvariantCheck.cpp	`95.9% <100.0%> (+0.5%)`	⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

a1q123456

lgtm

gregtatcam

LGTM

github-actions · 2026-06-10T23:21:22Z

This PR has conflicts, please resolve them in order for the PR to be reviewed.

…variants

github-actions · 2026-06-11T09:02:06Z

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

xrplf-ai-reviewer

Clean implementation. Ship it!

Review by Claude Sonnet 4.6 · Prompt: V15

Copilot

Pull request overview

This PR introduces a new transaction invariant intended to ensure certain ledger object types (AMM, Vault, LoanBroker) always reference a valid on-ledger pseudo-account, and extends unit tests to cover the new invariant behavior.

Changes:

Add a new ObjectHasPseudoAccount invariant that checks sfAccount is present and the referenced account root exists (behind fixCleanup3_3_0).
Update invariant wiring (InvariantChecks tuple) to include the new check.
Adjust invariant unit tests by setting sfAccount where needed and adding dedicated coverage for missing/nonexistent pseudo-accounts.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
src/test/app/Invariants_test.cpp	Updates Vault test setup to include `sfAccount` and adds a new invariant test for pseudo-account presence/existence.
src/libxrpl/tx/invariants/InvariantCheck.cpp	Implements the `ObjectHasPseudoAccount` invariant logic and logging.
include/xrpl/tx/invariants/InvariantCheck.h	Declares the new invariant and adds it to the public `InvariantChecks` tuple.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

Change ObjectHasPseudoAccount from checking "object exists → pseudo-account exists" to "object deleted → pseudo-account deleted". Together with AccountRootsDeletedClean (which enforces the reverse: pseudo-account deleted → object deleted), this pair of invariants guarantees that an object and its pseudo-account are always deleted as a unit.

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

github-actions · 2026-06-27T02:11:44Z

This PR has conflicts, please resolve them in order for the PR to be reviewed.

ximinez

Updates look good. You've got conflicts to resolve, though.

…variants

github-actions · 2026-06-30T07:42:47Z

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

xrplf-ai-reviewer

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

bthomee · 2026-07-01T12:48:54Z

+        // LCOV_EXCL_START
+        UNREACHABLE(
+            "xrpl::ObjectHasPseudoAccount::visitEntry : deleted ledger entry missing before state");
+        return;
+        // LCOV_EXCL_STOP


For a follow-up PR, it makes sense to add a new UNREACHABLE_IF macro, just like the XRPL_ASSERT_IF that was added previously.

Tapanito added 2 commits June 10, 2026 15:18

feat: adds an invariant to ensure a pseudo-account is not deleted

51e8887

Merge branch 'develop' into tapanito/pseudo-invariants

cc4e2b4

Tapanito requested review from a1q123456 and gregtatcam June 10, 2026 13:22

xrplf-ai-reviewer Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread src/libxrpl/tx/invariants/InvariantCheck.cpp Outdated

Comment thread include/xrpl/tx/invariants/InvariantCheck.h Outdated

a1q123456 requested changes Jun 10, 2026

View reviewed changes

Comment thread src/libxrpl/tx/invariants/InvariantCheck.cpp

Comment thread src/libxrpl/tx/invariants/InvariantCheck.cpp Outdated

fix: address PR reviewer comments

66693fb

Tapanito requested a review from a1q123456 June 10, 2026 15:17

xrplf-ai-reviewer Bot approved these changes Jun 10, 2026

View reviewed changes

a1q123456 approved these changes Jun 10, 2026

View reviewed changes

gregtatcam approved these changes Jun 10, 2026

View reviewed changes

github-actions Bot added the PR: has conflicts label Jun 10, 2026

Merge remote-tracking branch 'origin/develop' into tapanito/pseudo-in…

00425ee

…variants

github-actions Bot removed the PR: has conflicts label Jun 11, 2026

Tapanito added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. PR: has conflicts and removed PR: has conflicts labels Jun 11, 2026

xrplf-ai-reviewer Bot approved these changes Jun 11, 2026

View reviewed changes

bthomee requested a review from Copilot June 11, 2026 18:07

Copilot started reviewing on behalf of bthomee June 11, 2026 18:08 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Tapanito changed the title ~~feat: Add an invariant to ensure a pseudo-account exists~~ feat: Add an invariant to ensure object deletion also deletes its pseudo-account Jun 12, 2026

xrplf-ai-reviewer Bot approved these changes Jun 12, 2026

View reviewed changes

Tapanito force-pushed the tapanito/pseudo-invariants branch from 93dfbb5 to 0a8b12c Compare June 12, 2026 10:38

Merge branch 'develop' into tapanito/pseudo-invariants

fcb5e9e

Tapanito requested a review from gregtatcam June 12, 2026 10:39

xrplf-ai-reviewer Bot approved these changes Jun 25, 2026

View reviewed changes

gregtatcam previously approved these changes Jun 25, 2026

View reviewed changes

Merge branch 'develop' into tapanito/pseudo-invariants

58dcb0b

xrplf-ai-reviewer Bot approved these changes Jun 26, 2026

View reviewed changes

ximinez self-requested a review June 26, 2026 14:56

github-actions Bot added the PR: has conflicts label Jun 27, 2026

ximinez previously approved these changes Jun 30, 2026

View reviewed changes

Merge remote-tracking branch 'origin/develop' into tapanito/pseudo-in…

ad6e6e9

…variants

Tapanito dismissed stale reviews from ximinez and gregtatcam via ad6e6e9 June 30, 2026 07:42

github-actions Bot removed the PR: has conflicts label Jun 30, 2026

Tapanito requested review from a1q123456 and ximinez June 30, 2026 07:43

xrplf-ai-reviewer Bot approved these changes Jun 30, 2026

View reviewed changes

bthomee requested a review from Copilot June 30, 2026 10:29

Copilot started reviewing on behalf of bthomee June 30, 2026 10:30 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread src/libxrpl/tx/invariants/InvariantCheck.cpp

Comment thread src/test/app/Invariants_test.cpp

ximinez approved these changes Jun 30, 2026

View reviewed changes

gregtatcam approved these changes Jun 30, 2026

View reviewed changes

a1q123456 approved these changes Jul 1, 2026

View reviewed changes

Merge branch 'develop' into tapanito/pseudo-invariants

3c7d214

Tapanito added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jul 1, 2026

xrplf-ai-reviewer Bot approved these changes Jul 1, 2026

View reviewed changes

bthomee reviewed Jul 1, 2026

View reviewed changes

bthomee added this pull request to the merge queue Jul 1, 2026

Merged via the queue into develop with commit ea13be8 Jul 1, 2026
49 checks passed

bthomee deleted the tapanito/pseudo-invariants branch July 1, 2026 14:33

Uh oh!

Conversation

Tapanito commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

High Level Overview of Change

Context of Change

API Impact

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

a1q123456 left a comment

Choose a reason for hiding this comment

Uh oh!

gregtatcam left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 11, 2026

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 27, 2026

Uh oh!

ximinez left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

Uh oh!

bthomee Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Tapanito commented Jun 10, 2026 •

edited

Loading

codecov Bot commented Jun 10, 2026 •

edited

Loading