build: Align xrpld RPM packaging with DEB package#7529
Conversation
cfc80fb to
497fb2a
Compare
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
497fb2a to
a61534e
Compare
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7529 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.0%
=========================================
Files 1007 1007
Lines 76890 76890
Branches 8971 8971
=========================================
- Hits 63053 63042 -11
- Misses 13828 13839 +11
Partials 9 9 🚀 New features to boost your workflow:
|
mathbunnyru
left a comment
There was a problem hiding this comment.
Approved, if it will take less time in CI (please, check, when it's done)
mathbunnyru
left a comment
There was a problem hiding this comment.
Unfortunately, doesn't work:
PR / package / xrpld-rhel-gcc-release-amd64 (pull_request)Successful in 12m
a61534e to
d1fd10e
Compare
I saw that. I removed the knobs but I removed the thing that made it work also. Re-running. |
d1fd10e to
3961412
Compare
3961412 to
7740ee6
Compare
|
This brings RPM package validation into the same rough size/time class as Debian. For context:
The old RPM artifact was smaller, but it got there by spending about 10 extra minutes optimizing/compressing debug-package payloads for a disposable CI artifact. Debian is already the practical comparison point here: DWZ optimization is not viable there for Operationally, the debug-symbol packages are mostly useful when we need to analyze coredumps. The download data supports optimizing this path for CI latency rather than RPM debug artifact size.
Some of the debian debug downloads were us also. So for PR validation, I think it is reasonable to optimize for fast proof that the package builds rather than spending another ~10 minutes minimizing a short-lived RPM debug artifact that is rarely consumed. |
|
Almost as fast as deb now |
I think so too. 🤕 |
mathbunnyru
left a comment
There was a problem hiding this comment.
I left a couple of nit reviews to remove duplication, and to slightly improve style.
If you can, would be great to change these things (but please don't change anything beyond that, or re-request review)
Overall, LGTM 👍
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
normalize spaces rm comment rm dup flag explanation
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
The DEB package already skips the dwz debug optimization step because it takes a long time. This change brings RPM package validation into the same rough size/time class as Debian package generation.
Changes:
XRPLD_VERSION) stays distinct from the normalized package metadata version (pkg_version).For context from CI validation:
The old RPM artifact was smaller, but it spent about 10 extra minutes optimizing/compressing debug-package payloads for a short-lived CI artifact. Debian is already the practical comparison point here: DWZ optimization is not viable there for
xrpldtoday (Too many DIEs, not optimizing), and the Debian debug package still builds quickly.Operationally, debug-symbol packages are mostly useful when analyzing coredumps. The download data supports optimizing this path for CI latency rather than RPM debug artifact size. For
3.1.3, the stats were:Some of the Debian debug downloads were us too.