Skip to content

ci: Update workflows and conan to use VS2026 and grpc 1.81.0#7550

Merged
bthomee merged 6 commits into
developfrom
a1q123456/use-vs2026
Jun 23, 2026
Merged

ci: Update workflows and conan to use VS2026 and grpc 1.81.0#7550
bthomee merged 6 commits into
developfrom
a1q123456/use-vs2026

Conversation

@a1q123456

@a1q123456 a1q123456 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR updates the pipeline to use the visual studio 2026 runners and extends the timeout to allow windows runners to finish building dependencies

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@a1q123456 a1q123456 added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jun 16, 2026
@a1q123456 a1q123456 changed the title Update pipeline and conan to use vs2026 and grpc 1.81.0 ci: Update pipeline and conan to use vs2026 and grpc 1.81.0 Jun 16, 2026
@a1q123456 a1q123456 force-pushed the a1q123456/use-vs2026 branch from 138db79 to 933dfc0 Compare June 16, 2026 14:28
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.0%. Comparing base (ff02269) to head (4ee8c6e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7550     +/-   ##
=========================================
- Coverage     82.0%   82.0%   -0.0%     
=========================================
  Files         1007    1007             
  Lines        76873   76873             
  Branches      8973    8971      -2     
=========================================
- Hits         63012   63004      -8     
- Misses       13852   13860      +8     
  Partials         9       9             

see 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1q123456 a1q123456 requested a review from mathbunnyru June 16, 2026 20:02
@a1q123456 a1q123456 marked this pull request as ready for review June 16, 2026 20:02
@a1q123456 a1q123456 requested a review from bthomee June 16, 2026 20:03

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

@a1q123456

Copy link
Copy Markdown
Contributor Author

Making it a draft until I finish updating the devbox labels

@mathbunnyru mathbunnyru left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@a1q123456 a1q123456 marked this pull request as draft June 16, 2026 20:08
Comment thread .github/scripts/strategy-matrix/windows.json
@a1q123456 a1q123456 marked this pull request as ready for review June 16, 2026 20:41
@a1q123456 a1q123456 requested a review from bthomee June 16, 2026 23:34
@mathbunnyru mathbunnyru changed the title ci: Update pipeline and conan to use vs2026 and grpc 1.81.0 ci: Update workflows and conan to use VS2026 and grpc 1.81.0 Jun 17, 2026

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

@mathbunnyru mathbunnyru added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. and removed DraftRunCI Normally CI does not run on draft PRs. This opts in. labels Jun 23, 2026
@bthomee bthomee added this pull request to the merge queue Jun 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

@bthomee bthomee enabled auto-merge June 23, 2026 18:27
@bthomee bthomee added this pull request to the merge queue Jun 23, 2026
Merged via the queue into develop with commit 0b22050 Jun 23, 2026
81 of 83 checks passed
@bthomee bthomee deleted the a1q123456/use-vs2026 branch June 23, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants