Do not build an empty version range in the apache_httpd importer#2392
Open
Sanjays2402 wants to merge 1 commit into
Open
Do not build an empty version range in the apache_httpd importer#2392Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
to_version_ranges() returned ApacheVersionRange(constraints=constraints) unconditionally. When every candidate version is empty or ignorable the constraint list is empty and the range serializes to "vers:apache/", which VersionRange.from_string() later rejects with "specifies no version range constraints", so the whole AffectedPackage is dropped with a traceback. Return None instead when there are no constraints; the caller already skips building an AffectedPackage for a falsy range. Adds a regression test asserting the constraint-less case yields no range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2387
ApacheHTTPDImporterPipeline.to_version_ranges()always returnedApacheVersionRange(constraints=constraints). When every candidate version is empty or ignorable the constraint list is empty and the range serializes tovers:apache/, whichVersionRange.from_string()later rejects with "specifies no version range constraints" — soAffectedPackage.from_dictlogs the reported traceback and drops the package. ReturningNoneinstead lets the existingif affected_version_range:guard into_advisory()skip it cleanly.Regression test
test_to_version_ranges_without_constraintsfails on the unpatched code and passes with the fix.