Stabilize GIF and GIF emoji frame grids#63
Draft
achimala wants to merge 1 commit into
Draft
Conversation
Detect imprecise frame grid boundaries via edge profiles instead of naive equal splits. Crop each cell to its content, scale all frames with a shared factor, and center them on the output canvas to stop jiggle. Co-authored-by: Anshu Chimala <achimala@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GIF and GIF emoji frames were jiggling because the image model does not lay out sprite sheets on a perfectly even grid, and each frame was resized independently with
fit: "contain".This change stabilizes animation output in
processGifEmojiGrid(used by/gif,/gifemoji, and agent GIF generation).Changes
floor(width / gridSize)for every cell.Testing
pnpm lintpnpm build