Skip to content

feat: quote redesign#258

Open
jawinn wants to merge 5 commits into
mainfrom
feat-quote-redesign
Open

feat: quote redesign#258
jawinn wants to merge 5 commits into
mainfrom
feat-quote-redesign

Conversation

@jawinn

@jawinn jawinn commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary of changes

Updates design of quotes to use theme specific colored text, no borders, and adjusted padding and margin.

Relevant Links

Test URLs:

Checklist

  • This PR has visual changes, and has been reviewed by a designer.
  • This PR has code changes, and our linters still pass.
  • This PR affects production code, so it was browser tested (see below).

Validation

  1. Make sure all PR checks have passed.
  2. Pull down all related branches.
  3. Go to an article page with at least one quote. You can then paste this script into the console to swap between color themes to test the text colors.
(() => {
  const themes = [
    'theme--backdrop-blue-circles',
    'theme--backdrop-blue-green-wave',
    'theme--backdrop-blue-purple-fade',
    'theme--backdrop-green',
    'theme--backdrop-indigo',
    'theme--backdrop-seafoam',
    'theme--blue',
    'theme--cinnamon',
    'theme--cyan',
    'theme--fuchsia',
    'theme--indigo',
    'theme--no-color',
    'theme--orange',
    'theme--red',
    'theme--seafoam',
  ];
  let i = 0;
  document.addEventListener('click', () => {
    document.body.classList.remove(...themes);
    document.body.classList.add(themes[i % themes.length]);
    console.log(themes[i % themes.length]);
    i++;
  });
})();

  1. Confirm responsiveness of quote changes.

Example articles:

  • This one has subtitle text on a quote /ideas/behind-the-design-adobe-express-ai-assistant
  • This one has an unconventional use of quote for formatting purpose on a non-quote and would need to be modified (to discuss): /ideas/the-creative-cloud-features-adobe-s-designers-can-t-live-without1

Browser Testing

We should aim to support the latest version of the listed browsers. For older versions or other browsers not on the list, content should be accessible, even if it doesn't completely match the designs.

Developers should test as they work in the browsers available on their machines. If they have access to other devices to test other browser/OS combinations, they should do that when possible.

Windows

  • Firefox
  • Chrome
  • Edge

MacOS

  • Firefox
  • Chrome
  • Safari
  • Edge

Android

  • Firefox
  • Chrome
  • Edge

iOS

  • Safari

jawinn added 4 commits June 26, 2026 16:41
Add quote colors that match the backdrop themes using SVGs, as those
can also be used on any article. Also fixes a wrongly swapped light and
dark mode color (green-1400).
@aem-code-sync

aem-code-sync Bot commented Jun 26, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@aem-code-sync

aem-code-sync Bot commented Jun 26, 2026

Copy link
Copy Markdown
Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant