SCIX-890 fix(vis): keep paper limit and CSV reachable on empty network#905
Draft
thostetler wants to merge 1 commit into
Draft
SCIX-890 fix(vis): keep paper limit and CSV reachable on empty network#905thostetler wants to merge 1 commit into
thostetler wants to merge 1 commit into
Conversation
When the author or paper network can't be grouped, the page dropped the whole graph pane, so a user who over-restricted the paper limit had no way to raise it back up and nothing to export. The "not enough data" response also has a different shape than success (no root/summaryGraph; raw rows under fullGraph), which the CSV path wasn't reading. 1. Add NetworkNotEnoughData: the message plus the paper limit control and an optional CSV download, shared by both containers. 2. Build the error-state CSV from fullGraph.nodes (author name/weight; paper bibcode + metadata), omitting the button when there are no rows. 3. Model the fullGraph fallback in the vis types.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #905 +/- ##
========================================
+ Coverage 67.4% 67.6% +0.3%
========================================
Files 349 350 +1
Lines 41238 41334 +96
Branches 2132 2137 +5
========================================
+ Hits 27762 27912 +150
+ Misses 13427 13373 -54
Partials 49 49
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author and paper network pages dropped the entire graph pane when the
backend couldn't build groups, so a user who over-restricted the paper limit
had no way to raise it back and nothing to export. The "not enough data"
response also uses a different shape than success (no root/summaryGraph; raw
rows under fullGraph), which the CSV path wasn't reading.
screen and offers an optional CSV download.
paper bibcode and metadata), omitting the button when there are no rows.