feat: add matchExpressions support to Allocation Service#4630
Merged
markmandel merged 2 commits intoJun 26, 2026
Conversation
markmandel
added
area/user-experience
Collaborator
|
Build Failed 😭 Build Id: 9c126653-11e5-4f84-96fd-2eb884777550 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
markmandel
force-pushed
the
feature/allocator-label-selectors
branch
from
f477574 to
a8dc522
Compare
markmandel
commented
Jun 22, 2026
| map<string, string> annotations = 2; | ||
| } | ||
|
|
||
| // LabelMatchExpressions is a selector that contains values, a key, and an operator |
Member
Author
There was a problem hiding this comment.
this file get's copied over with make gen-all-sdk-grpc -- probably doesn't need to, but that's a cleanup task for another day.
Collaborator
|
Build Succeeded 🥳 Build Id: b6e565fd-b8c6-46b6-8bb3-1fe825ca3337 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
markmandel
force-pushed
the
feature/allocator-label-selectors
branch
from
a8dc522 to
564a17e
Compare
Collaborator
|
Build Failed 😭 Build Id: c3b9c356-49cd-41fc-8fdb-52ca38a44264 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
* Introduce `MatchExpressions` to `GameServerSelector` for enhanced label-based selection alongside `MatchLabels`. * Update allocation logic to convert match expressions between internal and external representations. * Add e2e test `TestAllocatorWithMatchExpressions` to validate these scenarios. Closes agones-dev#2028 Signed-off-by: Mark Mandel <mark@compoundtheory.com>
markmandel
force-pushed
the
feature/allocator-label-selectors
branch
from
564a17e to
06507ed
Compare
Collaborator
|
Build Succeeded 🥳 Build Id: 53199bfa-2ab0-4cbb-b8c8-a5b242cdd4b6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Collaborator
|
Build Succeeded 🥳 Build Id: a4ef1323-a0da-41a0-a2df-5f48b462297f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
MatchExpressionstoGameServerSelectorfor enhanced label-based selection alongsideMatchLabels.TestAllocatorWithMatchExpressionsto validate these scenarios.Which issue(s) this PR fixes:
Closes #2028
Did you use AI tools in preparing this PR?:
Y
Special notes for your reviewer:
This was in my brain, and was an easy thing to get Claude to do.