Fix autocomplete popup positioning with CSS transforms#5984
Open
cyphercodes wants to merge 2 commits into
Open
Fix autocomplete popup positioning with CSS transforms#5984cyphercodes wants to merge 2 commits into
cyphercodes wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5984 +/- ##
==========================================
- Coverage 93.73% 93.70% -0.03%
==========================================
Files 641 641
Lines 138167 138245 +78
Branches 14561 14552 -9
==========================================
+ Hits 129510 129546 +36
- Misses 8657 8699 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Added focused coverage for the transformed ghost-text popup positioning path that Codecov flagged. Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #5688
Description of changes:
hasCssTransformsis enabled.Verification:
npm test -- --grep "popup positioning accounts for editor css transforms"npx mocha ./src/autocomplete_test.js ./src/autocomplete/popup_test.js --exit --colornpx eslint src/autocomplete.js src/autocomplete_test.jsgit diff --check HEAD~1..HEADBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references:Open kitchen-sink @ 2cc6417e777f1e7a4666da6c86ed13d70a9aa673
Open kitchen-sink @ b399e9431752a2d4a63eceb2c0922df624582077