fetch etag for photo of contact and detect has_photo#21
Open
manme wants to merge 3 commits into
Open
Conversation
Owner
|
Hmm, I have a feeling the CI build is messed up because of some dependency issues, similar to in the other PR that's open right now. |
Author
|
uh, sounds bad, could you resolve this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we check photo of contact like href.nil?, but by default user has href of photo all time. We can check it by etag: https://developers.google.com/google-apps/contacts/v3/#retrieving_a_contacts_photo
Could anyone check and merge this update? Thanks!