Fix compiler deprecation warnings for Crystal 1.20+#1379
Merged
crimson-knight merged 1 commit intoJun 11, 2026
Conversation
Issue: None
# Why is this change necessary?
* Modern Crystal versions generate several deprecation warnings for outdated methods (Process::Status#exit_status, Time.monotonic, splat macro syntax, ::sleep).
# How does it address the issue
* Updated `exit_status` to `exit_code` in `src/amber/cli/commands/exec.cr`.
* Replaced `Time.monotonic` with `Time.instant` in `src/amber/cli/helpers/process_runner.cr`.
* Replaced `sleep 1` with `sleep 1.second` in `src/amber/cli/helpers/process_runner.cr`.
* Replaced double-brace macro splat syntax `{{*args}}` with `{{args.splat}}` in `src/amber/dsl/router.cr`.
# What side effects does this change have?
* None. Fixes compilation deprecation warnings when building the amber CLI binary.
Co-developed-by: Gemini AI <renich+gemini@woralelandia.com>
Signed-off-by: Rénich Bon Ćirić <renich@woralelandia.com>
crimson-knight
added a commit
to amberframework/amber_cli
that referenced
this pull request
Jun 10, 2026
…22) * Harden editor invocation against shell injection; fix Crystal 1.20 deprecations exec.cr and encrypt.cr previously called system("#{editor} #{filename}"), allowing shell metacharacters in the EDITOR env var or filename to execute arbitrary commands. Replace with Process.parse_arguments + Process.run so the editor string is word-split (supporting "code -w", "vim -u none", etc.) and the filename is passed as a literal argument with no shell involvement. Add regression specs asserting shell metacharacters in editor/filename do not execute. Fix pattern contributed by @tcoatswo in amberframework/amber#1376. process_runner.cr used Time.monotonic which is deprecated in Crystal 1.20.0 in favour of Time.instant (Time::Instant, introduced in 1.20.0). Replace both call sites. The shard.yml crystal floor is raised to >= 1.20.0 to match (see version bump commit). Fix contributed by @renich in amberframework/amber#1379. amber.js Channel.join/leave/push previously called this.socket.ws.send() without error handling; a dead WebSocket throws an uncaught DOMException in the browser. Wrap each send in try/catch with a fallback to _reconnect(). Fix pattern contributed by @jonsilverman50-star in amberframework/amber#1375. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Bump version to 2.0.1; raise Crystal floor to >= 1.20.0 Time.instant (used in process_runner.cr) was introduced in Crystal 1.20.0. Raise the shard.yml crystal constraint from >= 1.10.0 to >= 1.20.0 to reflect this requirement. Bump shard version 2.0.0 -> 2.0.1 to signal the patch release containing the exec/encrypt hardening and deprecation fixes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Member
|
Thanks for tracking down these deprecation warnings. Cleaning up Merging this into v1. For context on where these land in V2: the CLI was removed from the framework core entirely (exec.cr and process_runner.cr now live in the standalone amber_cli), and the router macro was rewritten with explicit named parameters, so the splat fix is superseded by design there. Your V2 is now public if you want to see where things are heading: #1383. We'd welcome the help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
When compiling the Amber framework under modern Crystal versions (e.g. 1.20+), several deprecation warnings are emitted. This Pull Request updates the deprecated methods to their modern equivalents:
Process::Status#exit_statustoProcess::Status#exit_codeinsrc/amber/cli/commands/exec.cr.Time.monotonicwithTime.instantinsrc/amber/cli/helpers/process_runner.cr.sleep 1with the modernsleep 1.secondspan-based signature insrc/amber/cli/helpers/process_runner.cr.{{*args}}with{{args.splat}}insrc/amber/dsl/router.cr.Alternate Designs
None. These changes follow standard deprecation warnings emitted during compilation.
Benefits
amberCLI binary under modern Crystal versions with 0 deprecation warnings.Possible Drawbacks
None.
Note: This PR was co-developed with the assistance of Gemini AI. The user (Rénich Bon Ćirić) has directed, reviewed, tested, and takes full responsibility for the code.