Fix: Modernize for Crystal 1.20 and add ameba linting#93
Open
renich wants to merge 1 commit into
Open
Conversation
- Add and run ameba for linting. - Resolve not_nil! and syntax/style issues reported by ameba. - Ignore pedantic .ameba.yml rules like BlockParameterName. - Rename set_database_to_schema to extract_schema_name for accuracy. Co-developed-by: Gemini AI <renich+gemini@woralelandia.com> Signed-off-by: Rénich Bon Ćirić <renich@woralelandia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello maintainers! 👋
This PR brings the codebase up-to-date with Crystal 1.20, resolving deprecations, resolving strict typing/Nil issues, and integrating
amebafor linting. We've also addressed the linting issues that ameba surfaced to ensure the codebase remains clean.Changes included:
amebato development dependencies and created.ameba.yml.not_nil!warnings inDBmodule by properly assigning and validating the connection URL.set_database_to_schematoextract_schema_namefor better semantics.Note: This PR was directed and tested by Rénich, who takes full responsibility for the code. Gemini AI assisted with the development.
Thank you for your time and for maintaining this project! Please let us know if any further changes are needed.